Skip to content

[Build] Add insight package to turbo run commands #6762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[Build] Add insight package to turbo run commands #6762

merged 1 commit into from
Apr 18, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 18, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR updates the package.json scripts to include the ./packages/insight filter in various development and build commands for multiple applications, enhancing their functionality.

Detailed summary

  • Added --filter=./packages/insight to the following scripts:
    • wallet-ui
    • wallet-ui:build
    • playground
    • portal
    • dashboard

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 2:04am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 2:04am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 2:04am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 2:04am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 2:04am

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: 4eb3139

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Apr 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review April 18, 2025 01:56
@codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.16%. Comparing base (c7cb6ae) to head (4eb3139).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6762   +/-   ##
=======================================
  Coverage   55.16%   55.16%           
=======================================
  Files         896      896           
  Lines       56910    56910           
  Branches     3938     3938           
=======================================
  Hits        31396    31396           
  Misses      25419    25419           
  Partials       95       95
Flag Coverage Δ
packages 55.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 3a43fb2 into main Apr 18, 2025
24 of 25 checks passed
@joaquim-verges joaquim-verges deleted the _Build_Add_insight_package_to_turbo_run_commands branch April 18, 2025 01:59
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.75 KB (0%) 1.1 s (0%) 251 ms (+79.08% 🔺) 1.3 s
thirdweb (cjs) 138.9 KB (0%) 2.8 s (0%) 405 ms (+18.09% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 90 ms (+788.16% 🔺) 202 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 38 ms (+1111.31% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 134 ms (+401.91% 🔺) 521 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges